Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#22] | add statistic result #71

Merged
merged 20 commits into from
Jul 11, 2023

Conversation

Abizrh
Copy link
Contributor

@Abizrh Abizrh commented Jul 10, 2023


title: Issue #22 | add statistic result

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

  • create result page for showing user statistic data

  • I use chart.js for statistic data

  • I just update the code

  • previously I use chart.js, then I changes into recharts so we only have one library of charts

  • change the structure of my file.

The stats data is still dummy, I have not connect to db yet.

Related Tickets & Documents

  • Related Issue #
  • Closes #

QA Instructions, Screenshots, Recordings

update-code

UI accessibility concerns?

So basically, if you completed your typing test then I'll change the page to the result chart

Added/updated tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Killbyfire
Copy link
Contributor

I made the dashboard using recharts, how about we just use recharts since its pretty easy and looks nice.

@Abizrh
Copy link
Contributor Author

Abizrh commented Jul 10, 2023

I made the dashboard using recharts, how about we just use recharts since its pretty easy and looks nice.

ohh so that is ur pr for issue #58, is that included the issue #22?

@Abizrh
Copy link
Contributor Author

Abizrh commented Jul 10, 2023

hold for merge

@Abizrh
Copy link
Contributor Author

Abizrh commented Jul 11, 2023

@webdevcody ready for merge

@webdevcody webdevcody merged commit 89087f6 into webdevcody:main Jul 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants